Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix MSVC x86_64 CI #230

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: Fix MSVC x86_64 CI #230

wants to merge 7 commits into from

Conversation

dc03
Copy link

@dc03 dc03 commented Jun 14, 2022

Hopefully this fixes the MSVC x86_64 CI.

@dc03 dc03 changed the title update: update vcpkgGitRef to update vcpkg version WIP: Fix MSVC x86_64 CI Jun 14, 2022
@dc03
Copy link
Author

dc03 commented Jun 16, 2022

I've added a few extra options to the cmake -G ... bit, those being -Dprotobuf_BUILD_TESTS=OFF -Dprotobuf_BUILD_SHARED_LIBS=ON -DPROTOBUF_LIBRARY="$(Build.BinariesDirectory)\vcpkg\packages\protobuf_x64-windows\lib\libprotobuf.lib", hopefully the first two are redundant however I have added them for now as they were there when it ran on my machine.

dc03 added 4 commits June 17, 2022 19:40
@dc03
remove stupid hack
e72b492
@dc03
Hopefully fix MSVC x64 CI.
031b00e 
On my VM, putting the Protobuf include before gRPC fixed protobuf linking against .dlls instead of .libs
@dc03
Update install() to use GET_PREREQUISITES_VERBOSE
d4f5e56
@dc03
change job names
471be24
@dc03 dc03 mentioned this pull request Jun 27, 2022
Merged
@dc03 dc03 mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dc03