Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: View reordering on re-addition to same parent #42115

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 10, 2024

Backport of #42085

See that PR for details.

Notes: Fixed a crash when the same WebContentsView is added via addChildView multiple times.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from codebytere and a team May 10, 2024 08:16
@trop trop bot added 30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels May 10, 2024
@codebytere codebytere merged commit 08abef6 into 30-x-y May 13, 2024
20 checks passed
@codebytere codebytere deleted the trop/30-x-y-bp-fix-view-reordering-on-re-addition-to-same-parent-1715328999628 branch May 13, 2024 11:01
Copy link

release-clerk bot commented May 13, 2024

Release Notes Persisted

Fixed a crash when the same WebContentsView is added via addChildView multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant