-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spacetime] Reimplement config Setting classe in java #15679
base: main
Are you sure you want to change the base?
[Spacetime] Reimplement config Setting classe in java #15679
Conversation
Quality Gate failedFailed conditions0.0% Coverage on New Code (required ≥ 80%) |
221c355
to
c5e4e28
Compare
…apper around the new one
…the wrapped Java Setting
…ethod to create a copy of the wrapped Java Setting with the deprecated setting name
…wrapped Java Setting class
…om the wrapped Java Setting class
…wrapped Java Setting class
e688d12
to
560e8c3
Compare
clone.instance_variable_set(:@name, alias_name) | ||
clone.instance_variable_set(:@default, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewer:
nulling the default value is already done by the deprecate
method when create the new instance of the Java Setting
class.
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
cc @andsel |
Release notes
[rn:skip]
What does this PR do?
Reimplement the root Ruby Setting class in Java and use it from the Ruby one, wrapping the Java instance.
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs