Fix multithreading copies in lib vec #108802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>bug
Team:Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @ChrisHegarty, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
ChrisHegarty
added
auto-merge
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/bwc-snapshots |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
💔 Backport failed
You can use sqren/backport to manually backport by running |
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
May 19, 2024
This commit fixes a potential multithreading issue with the lib vec vector scorer. Since the implementation falls back to a lucene scorer which needs to read from the index input, then we need to make a copy of the index input. Otherwise, there is a potential for the stateful index input to be accessed across threads - which would be bad. The fallback is only used when one or other vector cross a segment boundary, which is 16G by default. So the likelihood of this occurring in practice is small, but the affect is bad. The fix is deliberately small and targeted, so that it can be backported. After this change, I'm going to drop the custom VectorScorer and adapter type, in favour of using the Lucene type directly. This custom types were initially used when the code lived inside the native module, where we didn't want to add a dependency on Lucene directly.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a potential multithreading issue with the lib vec vector scorer.
Since the implementation falls back to a lucene scorer which needs to read from the index input, then we need to make a copy of the index input. Otherwise, there is a potential for the stateful index input to be accessed across threads - which would be bad.
The fallback is only used when one or other vector cross a segment boundary, which is 16G by default. So the likelihood of this occurring in practice is small, but the affect is bad.
The fix is deliberately small and targeted, so that it can be backported. After this change, I'm going to drop the custom VectorScorer and adapter type, in favour of using the Lucene type directly. This custom types were initially used when the code lived inside the native module, where we didn't want to add a dependency on Lucene directly.