Disable auto-expand functionality for stateless indices #108797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
force-pushed
the
enhancement/disable_auto_expand_stateless
branch
from
ddf7f17
to
76e6ffa
Compare
Replicas are automatically managed in stateless, hence auto-expand replicas needs to be disabled for stateless indices in order for it not to conflict with the automatic management of replicas for indices. As a result, stateless indices won't see auto-expand take any effect due to applying auto-expand replicas from the ES codebase. There is an edge-case for indices that do set number of replicas to 0 manually as well as auto_expand_replicas as part of index settings: in that case we force such value to be 1 rather than 0.
javanna
force-pushed
the
enhancement/disable_auto_expand_stateless
branch
from
7cebdc8
to
35da6d5
Compare
javanna
added
:Distributed/Distributed
javanna
commented
May 24, 2024
| indexMetadata.getSettings().get(ExistingShardsAllocator.EXISTING_SHARDS_ALLOCATOR_SETTING.getKey()), | ||
| "stateless" | ||
| )) { | ||
| if (indexMetadata.getNumberOfReplicas() == 0) { |
There was a problem hiding this comment.
I opened #108994 to at least partially address this situation, where we create indices providing auto_expand_replicas config as well as number_of_replicas, but that won't cover all cases. There's one case of the enrich index that gets created with number of replicas set to 0, and only later updated to get auto expanded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicas are automatically managed in stateless, this commit disabled auto-expand replicas for stateless indices. As a result, stateless indices won't see auto-expand take any effect. Such indices will have their replicas auto-managed like any other index.
Note: the auto-expand functionality is already disabled for stateless indices, by always returning 1 as desired number of replicas. What this PR does is skipping stateless indices entirely, so that we don't make any decision around auto-expanding, instead of forcing 1. The end result will be the same in terms of number of replicas, because 0 will be rewritten to 1 anyways, but values that differ from 0 will be left as-is instead of rewritten to 1 at all times.