[ML] Add option to disable inference process cache by default #108784
+96
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
failure due to esql IT |
|
@elasticmachine merge upstream |
| } | ||
|
|
||
| private static CreateTrainedModelAssignmentAction.Response createResponse() { | ||
| return new CreateTrainedModelAssignmentAction.Response(mock(TrainedModelAssignment.class)); |
There was a problem hiding this comment.
Instead of mocking it and needing remove final can you use the tests helper?
Or is it not accessible?
There was a problem hiding this comment.
Actually, it's protected...so instead you could create a public method in that class that exposes it or you can just do what it's doing:
return new Response(TrainedModelAssignmentTests.randomInstance());
There was a problem hiding this comment.
I hadn't even considered that the object's tests would have their own instantiation function. Thanks!
jonathan-buttner
approved these changes
May 17, 2024
|
@elasticmachine merge upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent issues with the inference process cache in severless, we are adding the option to disable the inference process cache by default. On its own, this PR should have no functional effect. Once the corresponding elasticsearch-serverless PR is merged, the cache will be disabled on serverless.
This change will always allow the user to manually set the inference process cache.