Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate definition #783

Merged
merged 25 commits into from
May 12, 2022
Merged

Duplicate definition #783

merged 25 commits into from
May 12, 2022

Conversation

LucieLamothe
Copy link
Collaborator

Resolving PR #782

Each commit must modify one duplicate definition.

@LucieLamothe
Definition modified - cell line name
dbb7ee4 
Updated defintion for data_2316, data_2317, data_2318, data_2319, data_2320
@LucieLamothe
Modified definition of XMFA format_3811
f12456f 
and rdfs:seeAlso ressource added
@LucieLamothe
Updated the GFA defintion format_3976
5fd35a8 
Added synonym and comment
@LucieLamothe
Deprecated GenomeReview ID format_2751
63d38ba
@LucieLamothe
Deprecation of Virus ID data_2913
5363424 
Parent of Virus identifier changed to Identifier by type of entity (earlier identifier by tye of data)
@LucieLamothe
Upated defintion of Protein family ID (GeneFarm) data_2731
3e74227
@LucieLamothe
Updated defintion of Quality control report data_3914
2a07c0b
@LucieLamothe
Fixed typo
ffacd75
@LucieLamothe
Fixed typo
73b4254
@LucieLamothe
Updated definition User ID (now Account authentication) data_2101
5df9ce8 
Also updated defintion of Password data_1690 and Username data_1689
@LucieLamothe
Updated defintion of Person identifier data_2118
394a282
@LucieLamothe
First changes in EMBL format (XML) arborescence
239e5b4
@LucieLamothe
Updated defintion of insdxml format_2185
5ae6401 
Documentation and reference article added
@LucieLamothe
Update defintion of LinucsID data_2796 and GlycoMap ID data_2752
7d56d0d
@LucieLamothe
insdwml changes to INSDSeq
3d3d97d
@LucieLamothe
Fixed INSDSeq format_2185
cd22e2e
@LucieLamothe
Updated defintion and documentation of cdsxml format_2184 and EMBLXML…
76604a3 
… format_2183
@matuskalas matuskalas marked this pull request as draft December 14, 2021 23:50
matuskalas
matuskalas reviewed Dec 15, 2021
View reviewed changes
EDAM_dev.owl Outdated Show resolved Hide resolved
matuskalas
matuskalas requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to first be untagled from the other branches.

git switch duplicate_definition
git reset --hard 76604a3
git push -f git@github.com:LucieLamothe/edamontology.git duplicate_definition

@hmenager hmenager self-requested a review January 26, 2022 15:33
@hmenager hmenager marked this pull request as ready for review January 26, 2022 15:33
@matuskalas matuskalas self-requested a review January 26, 2022 15:37
hmenager
hmenager previously approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@hmenager hmenager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending very minor issues discussed with @LucieLamothe and @matuskalas !

matuskalas
matuskalas reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for me: Do one more spell check locally.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@LucieLamothe LucieLamothe mentioned this pull request May 10, 2022
Open
7 tasks
@matuskalas matuskalas added this to In progress in release 1.26 via automation May 12, 2022
@matuskalas matuskalas added bug Something isn't working polishing Does not extend the content or functionality, but improves other qualities labels May 12, 2022
This was referenced May 12, 2022
Open
Open
matuskalas
matuskalas requested changes May 12, 2022
View reviewed changes
Copy link
Member

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome, I love the progress on all of these ❤❤❤

There are only very minor fixes left to be done.

And all the things for revising later have now been moved into separate issues. 🚩

EDAM_dev.owl Show resolved Hide resolved
EDAM_dev.owl Show resolved Hide resolved
EDAM_dev.owl Show resolved Hide resolved
EDAM_dev.owl Show resolved Hide resolved
EDAM_dev.owl Show resolved Hide resolved
release 1.26 automation moved this from In progress to Review in progress May 12, 2022
@matuskalas
Fixed minor typos
54a2746 
and so 😊
 - very slightly improved 1 definition
 - removed 1 nonsense synonym
 - updated the date📅)
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

release 1.26 automation moved this from Review in progress to Reviewer approved May 12, 2022
matuskalas
matuskalas approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this now done? 😋

@matuskalas matuskalas marked this pull request as draft May 12, 2022 15:24
@matuskalas matuskalas marked this pull request as ready for review May 12, 2022 21:08
@matuskalas matuskalas marked this pull request as draft May 12, 2022 22:18
@matuskalas matuskalas marked this pull request as ready for review May 12, 2022 22:50
@matuskalas matuskalas merged commit 5705316 into edamontology:main May 12, 2022
release 1.26 automation moved this from Reviewer approved to Done May 12, 2022
@matuskalas matuskalas added the done - staged for release Done, will appear in the next stable release label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matuskalas matuskalas matuskalas approved these changes

@hmenager hmenager hmenager left review comments

Assignees

@matuskalas matuskalas

Labels
bug Something isn't working done - staged for release Done, will appear in the next stable release manual merge needed polishing Does not extend the content or functionality, but improves other qualities
Projects
release 1.26
Done
Milestone
1.26
Development

Successfully merging this pull request may close these issues.

Duplicate definition
3 participants
@LucieLamothe @matuskalas @hmenager