Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an Oomph configuration #3030

Merged
merged 1 commit into from May 12, 2024
Merged

Conversation

merks
Copy link
Contributor

@merks merks commented May 6, 2024

No description provided.

@merks
Copy link
Contributor Author

merks commented May 6, 2024

@cdietrich @LorenzoBettini

Of course this can be refined and modified to suit your needs. Once has been committed, a badge icon should be generated and I can help you link like I showed for other projects. (But I travel soon and have little time this week.)

@LorenzoBettini
Copy link
Contributor

@merks I wasn't aware of this feature, thanks!

Can we experiment with that with the current PR somehow?

@cdietrich shall we try that?

@cdietrich
Copy link
Member

We can but I won’t find time to try it out myself

@merks
Copy link
Contributor Author

merks commented May 9, 2024

If you check out the PR into a workspace, you can drag and drop the XtextConfiguration.setup resource itself onto an installer's title area to try it out.

Until it's checked in, the documentation link will not display the description HTML like it does for this page:

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-oomph/oomph/master/setups/configurations/OomphConfiguration.setup&show=true

And there will not exist a generated badge like this one:

https://download.eclipse.org/oomph/www/setups/svg/oomph.svg

Both of those are supported only by the processing done by this job after you commit the changes:

https://ci.eclipse.org/oomph/job/setup-archiver/

Note that its important that the Xtext setup has a reference to the configuration as I've done here.

When this is committed, I can help further. (And it goes without saying that of course you can change it in the future should you think other ways to simplify/guide the user's choices.)

@merks
Copy link
Contributor Author

merks commented May 12, 2024

It's a bit ironic that a contribution intended purely to make contribution easier (a contribution that has no impact on existing functionality neither in the code nor in the existing Oomph project setup) languishes for a week. I expect everyone is very busy with other things just like me so I do understand, but, if I were average-Jane user, I would be a little more annoyed with every passing day

@cdietrich
Copy link
Member

(a contribution that has no impact on existing functionality neither in the code nor in the existing Oomph project setup

this I could not derive from the pr without trying it out myself

@cdietrich cdietrich merged commit 4a00289 into eclipse:main May 12, 2024
6 checks passed
@cdietrich
Copy link
Member

Let’s see what happens if this is deployed

@LorenzoBettini
Copy link
Contributor

It's a bit ironic that a contribution intended purely to make contribution easier (a contribution that has no impact on existing functionality neither in the code nor in the existing Oomph project setup) languishes for a week. I expect everyone is very busy with other things just like me so I do understand, but, if I were average-Jane user, I would be a little more annoyed with every passing day

@merks indeed I had a busy week. Otherwise, I'd usually be more reactive O:)

@merks merks deleted the pr-oomph-configuration branch May 12, 2024 08:20
@merks
Copy link
Contributor Author

merks commented May 12, 2024

Here is the markup you can use in any *.md file:

Create Eclipse Development Environment for Xtext

E.g., on your contributing page in this section:

https://github.com/eclipse/xtext/blob/main/CONTRIBUTING.md#set-up-your-eclipse-workspace


The page it opens looks like this:

image


Using it, the installer advances to this page:

image

Because on the first page it selected this:

image

And the second page it selected this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants