assertNoErrors/Issues in CompilationTestHelper.Result #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szarnekow there's also this proposal |
LorenzoBettini
force-pushed
the
lb_compilation_test_result
branch
from
14cac5d
to
2f09e5f
Compare
szarnekow
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often check for errors/issues when using CompilationTestHelper, and I always have to retrieve errors/warnings, do the filtering, and check for emptiness.
I thought adding such methods to
Resultwould be worthwhile.assertNoWarningsdoesn't seem necessary to me, but I can add it in case.