Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS Arm in GitHub Actions #3015

Merged
merged 4 commits into from May 14, 2024
Merged

Use macOS Arm in GitHub Actions #3015

merged 4 commits into from May 14, 2024

Conversation

LorenzoBettini
Copy link
Contributor

Closes #3014

macOS arm is much faster than macOS x86, almost as Ubuntu.

@@ -14,7 +14,7 @@ jobs:
if: github.event_name != 'pull_request' || github.event.pull_request.base.repo.clone_url != github.event.pull_request.head.repo.clone_url
strategy:
matrix:
os: ['ubuntu-22.04', 'macos-12', 'windows-2022']
os: ['ubuntu-22.04', 'macos-14', 'windows-2022']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we also have cocoa x86_64 in our env, should we still run against macos-12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szarnekow we could, but we'd lose the advantage of faster macOS environment in GitHub Actions ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. It would be even faster if we skip all environments, no? Kidding.

Question is: What do we aim for? Short build times or more coverage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. It would be even faster if we skip all environments, no? Kidding.

And we would even have less releng/CI troubles! ;)

Question is: What do we aim for? Short build times or more coverage?

I see your point. I can also put back the old macOS x86 configuration. We can then decide whether to ditch one if it becomes too flaky

@LorenzoBettini
Copy link
Contributor Author

@szarnekow I've updated the PR accordingly.

I forgot to mention: the jobs will run in parallel but now we have lots of them, and one more once #2986 is merged. I think Eclipse has been granted more GitHub Actions processing time, is that right @cdietrich ? If it's so, it shouldn't be a big problem having so many jobs.

@LorenzoBettini
Copy link
Contributor Author

@szarnekow @cdietrich macOS x86 in GitHub Actions is getting unusable. Mac 12 is so slow that it almost always fails in building in UI tests. I've just tried Mac 13 but it also fails with "process returned error code 143".

I'd switch to macOS Arm, which, as I said above, is as fast as Ubuntu, and seems reliable.
In the end, since we build on macOS anyway, I don't think we miss crucial cases if we only build on arm.

@LorenzoBettini LorenzoBettini added this to the Release_2.35 milestone May 14, 2024
@LorenzoBettini LorenzoBettini merged commit 93b3860 into main May 14, 2024
9 of 10 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_3014 branch May 14, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use macOS Arm on GitHub Actions
3 participants