-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Helm Chart implementation #3036
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: kamiKAZIK <eduardas.kazakas@gmail.com>
{{ .Values.mosquitto.configFile }} | ||
{{- if .Values.mosquitto.authentication.passwordFile }} | ||
password_file {{ required ".Values.mosquitto.authentication.passwordFilePath is required!" .Values.mosquitto.authentication.passwordFilePath | quote }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no password file then you should probably add allow_anonymous true
since I don't see a way to enable an auth plugin with this chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardillb this is actually possible to set-up by adding necessary values using:
{{ .Values.mosquitto.configFile }}
{{- end -}} | ||
|
||
{{- define "mosquitto.capabilities.ingress.apiVersion" -}} | ||
{{- if semverCompare "<1.14-0" (include "mosquitto.capabilities.kubeVersion" .) -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last supported version of kube (not EOL) is 1.27, I don't think you need to support 10 year old versions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am more inclined to keep this, as it is already implemented and maybe there are some unlucky guys that are stuck with some very old k8s versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you! I feel it keeps complexity for something very, very old that is EOL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I indeed would keep the release process in a different PR.
I'd suggest adding a Makefile / similar (and run it in this PR) with https://github.com/norwoodj/helm-docs
.PHONY: helm-docs
helm-docs:
go run github.com/norwoodj/helm-docs/cmd/helm-docs@latest
Side note: I'm not a maintainer at all.
@hardillb do you know if we can merge this in? it would be highly appreciated. |
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make test
with your changes locally?Greetings, I would like to contribute this Helm Chart for Mosquitto project. I would love if anyone could review it and write down necessary fixed, if there have to be any. It would be nice and useful if the project has it's own officially supported Helm Chart to speed up deployments on Kubernetes.