add AbstractTest and AbstractTestWithProject #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebthom
force-pushed
the
abstract-test
branch
9 times, most recently
from
5d34b11
to
095e43f
Compare
sebthom
force-pushed
the
abstract-test
branch
2 times, most recently
from
995d94f
to
2483249
Compare
sebthom
force-pushed
the
abstract-test
branch
from
2483249
to
33c077f
Compare
sebthom
force-pushed
the
abstract-test
branch
2 times, most recently
from
285939b
to
1f528d6
Compare
|
@sebthom , it looks like you need to bump some version numbers. All that can be done to improve the tests is welcome :) |
@rubenporras It was a network issue of the jenkins infrastructure (some deps could not be located). rerunning the build fixed it. |
|
@rubenporras any other thoughts in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adhering to the DRY principle, this PR introduces two new abstract classes AbstractTest and AbstractTestWithProject. This saves 300 lines of repetitive boilerplate statements and fixes inconsistencies in test case setup.
One of the main drivers for this PR is, that I am still getting a lot of random test failures when executing the test suite locally on Windows and Ubuntu. This PR is part of an effort to get to the root of it by streamlining the test setup.