Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve code action only if edit and command are null (vscode behavior). #614

Closed

Conversation

angelozerr
Copy link
Contributor

Resolve code action only if edit and command are null (vscode behavior).

@mickaelistria
Copy link
Contributor

I don't think this is correct according to the spec. The relevant part in the spec says "In general, a client should offer data support if it offers resolve support. It should also be noted that servers shouldn’t alter existing attributes of a code action in a codeAction/resolve request.", but in case one of the attributes is null, it can be changed in resolved.
So I think we can skip resolve when edit != null && command != null as we already have the final value for actionable attributes; but in case one isn't set, we may still need resolve to fill on of them.

@eclipsewebmaster eclipsewebmaster deleted the branch eclipse:master May 21, 2024 14:09
@mickaelistria
Copy link
Contributor

The initial target branch master was deleted and replaced by main, so this PR got closed automatically. If this is still relevant, please re-create this PR targetting the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants