Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #182 by changing the styling bits of the shell and text field #183

Closed

Conversation

gayanper
Copy link
Contributor

The shell styling is changed to match AbstractInformationControl so the
same styles will get applied from themes. The text style bits are
updated to make it appear same as in different eclipse outline controls.

The shell styling is changed to match AbstractInformationControl so the
same styles will get applied from themes. The text style bits are
updated to make it appear same as in different eclipse outline controls.
@sebthom
Copy link
Member

sebthom commented Jul 25, 2022

@gayanper thanks for your contribution!
would you mind adding two screenshots (before/after) illustrating the effect of your change?

@gayanper
Copy link
Contributor Author

@gayanper thanks for your contribution!
would you mind adding two screenshots (before/after) illustrating the effect of your change?

Before

After

@gayanper
Copy link
Contributor Author

@sebthom Any feedback ?

@sebthom
Copy link
Member

sebthom commented Jul 28, 2022

@gayanper LGTM but I would like to leave the decision to @mickaelistria because of his comment at #182 (comment)

@sebthom
Copy link
Member

sebthom commented Oct 24, 2022

@mickaelistria WDYT?

@mickaelistria
Copy link
Contributor

I usually prefer sticking to default settings, and consider those discussions in a more global way. I don't think it's (been) a good thing that each project implements slight tweaks over sticking to default. In the end, it brings more inconsistency and more maintenance effort.

@eclipsewebmaster eclipsewebmaster deleted the branch eclipse:master May 21, 2024 14:09
@mickaelistria
Copy link
Contributor

The initial target branch master was deleted and replaced by main, so this PR got closed automatically. If this is still relevant, please re-create this PR targetting the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants