Gh 4581 remove jerven design mistakes

[JervenBolleman]

GitHub issue resolved: #

Briefly describe the changes proposed in this PR:

Remove LimitedSize evaluation strategy code, as well as a few methods in the EvaluationStrategy API that was replaced by the collection factory API.

Closes #4581

[JervenBolleman]

@hmottestad could this still be included in the next 5.x Milestone build?

[hmottestad]

@hmottestad could this still be included in the next 5.x Milestone build?

Yeah. I haven't started on the build process yet. I saw you requested a review from me, so I'll take a look asap.

[hmottestad]

Should this maybe be try-finally or is super.handleClose() only supposed to be called when there is an exception?

[JervenBolleman]

This should be a try-finally, although right now super.handleClose is a noop. That could change in the future.
will-fix.

[hmottestad]

From what I understand looking through the code you've moved the set creation to a higher level in the code (EvaluationFactory?) so that it's easier to override in the specific stores.

Only issue I found in your code was the try-catch instead of try-finally. If you're happy with everything then you can go ahead and merge.

[JervenBolleman]

From what I understand looking through the code you've moved the set creation to a higher level in the code (EvaluationFactory?) so that it's easier to override in the specific stores.

Only issue I found in your code was the try-catch instead of try-finally. If you're happy with everything then you can go ahead and merge.

Yes. Exactly, now with collection factories one does not need to extend the store. One can just inject the limited size collections. Also now there are fewer and fewer places left where collections are not coming from a collection factory that can spill to disk. So the original goal I had with these LimitedSize* all those years ago is no longer valid.