GH-4324 update pr verify actions #4325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
Comment on lines
+18
to
+24
| - name: Cancel workflow on failure | ||
| uses: vishnudxb/cancel-workflow@v1.2 | ||
| if: failure() | ||
| with: | ||
| repo: eclipse/rdf4j | ||
| workflow_id: ${{ github.run_id }} | ||
| access_token: ${{ github.token }} |
There was a problem hiding this comment.
I think that if we make this its own job, we can get rid of this cancel step.
There was a problem hiding this comment.
Yes, but don't we want to cancel the other jobs because they will need to run with the next push that has a formatting fix? So cancelling now saves some energy?
There was a problem hiding this comment.
Ah good point. I had it in my head that this would only cancel the current job - but if it also kills the parallel jobs then it's definitely worth leaving in.
abrokenjester
changed the title
abrokenjester
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #4324
Briefly describe the changes proposed in this PR:
Use a new java action that has maven caching build in.
Also move the formatting check into one place that is named after it.
PR Author Checklist (see the contributor guidelines for more details):