Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off heap Changes #19389

Merged
merged 8 commits into from
Jun 8, 2024
Merged

Off heap Changes #19389

merged 8 commits into from
Jun 8, 2024

Conversation

rmnattas
Copy link
Contributor

Revert "Add APIs to help with array access":

OffHeap changes:

  • Use dataAddr field for array access in Walker.cpp
  • Teach DAA about dataAddr pointer
  • Update IdiomRecognitionUtils.cpp to use new TransformUtil APIs
  • Teach J9RecognizedCallTransformer.cpp about dataAddr pointer
  • Update VectorAPIExpansion.cpp to use new TR::TransformUtil APIs
  • Use dataAddr pointer in _jitProfileStringValue
  • Update dereferenceStructPointerChain to use dataAddr field

@rmnattas rmnattas force-pushed the off-heap-merge2 branch 2 times, most recently from 810c5bf to f620ba7 Compare May 21, 2024 12:53
@rmnattas rmnattas marked this pull request as ready for review May 22, 2024 14:15
@rmnattas rmnattas requested a review from dsouzai as a code owner May 22, 2024 14:15
zl-wang
zl-wang requested changes May 30, 2024
View reviewed changes
runtime/compiler/ilgen/J9ByteCodeIlGenerator.hpp Outdated Show resolved Hide resolved
runtime/compiler/ilgen/Walker.cpp Outdated Show resolved Hide resolved
runtime/compiler/optimizer/J9TransformUtil.hpp Outdated Show resolved Hide resolved
runtime/compiler/runtime/JitRuntime.cpp Show resolved Hide resolved
rmnattas and others added 8 commits May 30, 2024 15:55
@rmnattas
Revert "Add APIs to help with array access"
0d34dab 
This reverts commit e766755.
APIs implementation were moved to OMR in
eclipse/omr@0aaf99b
@VermaSh @rmnattas
Use dataAddr field for array access in Walker.cpp
64e8bbc 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Teach DAA about dataAddr pointer
889d0bd 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Update IdiomRecognitionUtils.cpp to use new TransformUtil APIs
a8295da 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Teach J9RecognizedCallTransformer.cpp about dataAddr pointer
11be536 
Update process_java_lang_StringCoding_encodeASCII to use new
TransformUtil APIs for generating array access trees.

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Update VectorAPIExpansion.cpp to use new TR::TransformUtil APIs
566a656 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Use dataAddr pointer in _jitProfileStringValue
eee417c 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh @rmnattas
Update dereferenceStructPointerChain to use dataAddr field
cfe3deb 
Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@zl-wang
Copy link
Contributor

zl-wang commented Jun 7, 2024

Jenkins test sanity.functional plinux,xlinux,zlinux jdk8,jdk11

@zl-wang
Copy link
Contributor

zl-wang commented Jun 8, 2024

pLinux machine resource is lacking ...

@zl-wang zl-wang merged commit 30e0d8c into eclipse-openj9:master Jun 8, 2024
10 of 13 checks passed
@pshipton pshipton mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zl-wang zl-wang zl-wang requested changes

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmnattas @zl-wang @VermaSh