Split warm and cold blocks #19272
Merged
Split warm and cold blocks #19272
+34
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gita-omr
commented
Apr 4, 2024
•
gita-omr
commented
- identify last warm instruction during instruction selection
- the code is only enabled if -Xjit:splitWarmAndColdBlocks option is on
gita-omr
force-pushed
the
split_warm_cold_blocks
branch
from
62d10e7
to
46ecafe
Compare
|
Addressed comments in the OMR PR. |
gita-omr
added this to the Release 0.46 (Java 8, 11, 17, 21, 22) July refresh milestone
|
Jenkins test sanity all jdk17 |
0xdaryl
reviewed
May 17, 2024
| @@ -2166,6 +2170,25 @@ J9::CodeGenerator::doInstructionSelection() | |||
| if (doEvaluation) | |||
| self()->evaluate(node); | |||
|
|
|||
| if (opCode == TR::BBEnd) | |||
There was a problem hiding this comment.
Does this code need to be guarded with self()->comp()->getOption(TR_SplitWarmAndColdBlocks) too? It seems only useful for that optimization.
There was a problem hiding this comment.
isLastWarmBlock() is only true if the option is on. But I added the check to make the code more clear.
- identify last warm instruction during instruction selection - the code is only enabled if -Xjit:splitWarmAndColdBlocks option is on
gita-omr
force-pushed
the
split_warm_cold_blocks
branch
from
46ecafe
to
17bed20
Compare
|
Addressed comments above. |
|
Jenkins test sanity all jdk17 |
|
Jenkins test sanity xlinux jdk17 |
|
AIX build timed out. Linux build is waiting on an xlinux compile machine which are all offline. |
0xdaryl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.