Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores(readme): Fix typo - devel -> delve #885

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

vamsi4845
Copy link
Contributor

@vamsi4845 vamsi4845 commented May 16, 2024

Description

Fixed a typo in the README file. "devel" was incorrectly used instead of "delve"

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@vamsi4845 vamsi4845 requested a review from a team as a code owner May 16, 2024 18:30
@omritoptix omritoptix changed the title chore(README): Fix typo - devel -> delve chores(readme): Fix typo - devel -> delve May 20, 2024
omritoptix
omritoptix previously approved these changes May 20, 2024
@vamsi4845 vamsi4845 requested a review from omritoptix May 20, 2024 15:01
@vamsi4845
Copy link
Contributor Author

vamsi4845 commented May 20, 2024

I've misclicked request for the review @omritoptix sorry for that

danwt
danwt previously approved these changes May 21, 2024
@danwt
Copy link
Contributor

danwt commented May 21, 2024

conflicts

@vamsi4845 vamsi4845 dismissed stale reviews from danwt and omritoptix via 0d63985 May 21, 2024 09:50
@vamsi4845
Copy link
Contributor Author

@danwt I've fixed the conflicts

@mtsitrin mtsitrin merged commit 939fad7 into dymensionxyz:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants