Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(vfc): use utility to revert dirty state since VFBC deployment no longer handle dirty state #736

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VictorTrustyDev
Copy link
Contributor

@VictorTrustyDev VictorTrustyDev commented Mar 26, 2024

Description

@mtsitrin asked to changed the behavior:

  • Deployment method should not handle revert dirty state itself.
  • It's caller responsibility to handle revert dirty state.

TODO:

  • Wait for merge PR
  • Create tag for Ethermint
  • Update new tag to this PR

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.64%. Comparing base (3b4b731) to head (eb27f7f).
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   30.64%   30.64%           
=======================================
  Files         233      233           
  Lines       32580    32580           
=======================================
  Hits         9984     9984           
  Misses      21031    21031           
  Partials     1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix
Copy link
Contributor

@VictorTrustyDev is this still relevant or can we close it?

@VictorTrustyDev
Copy link
Contributor Author

@omritoptix it's Dymension decision, you can close if not wanted this code or solution for the situation had been handled else where.

Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added Stale and removed Stale labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants