Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Dockerfiles for fraud proof poc #580

Draft
wants to merge 11 commits into
base: fraud_proof_poc
Choose a base branch
from
Draft

chore: add Dockerfiles for fraud proof poc #580

wants to merge 11 commits into from

Conversation

artemijspavlovs
Copy link
Contributor

Description

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpeted math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner February 19, 2024 15:14
@artemijspavlovs artemijspavlovs force-pushed the artemijspavlovs/fraud-proof-docker branch 2 times, most recently from ea6ac5b to e1adfbd Compare February 19, 2024 15:42
@artemijspavlovs artemijspavlovs force-pushed the artemijspavlovs/fraud-proof-docker branch from e1adfbd to 1bf25dd Compare February 19, 2024 16:00
@omritoptix omritoptix changed the title feat: add Dockerfiles for fraud proof poc chore: add Dockerfiles for fraud proof poc Feb 21, 2024
@danwt
Copy link
Contributor

danwt commented Apr 8, 2024

I will reopen this at some point

@danwt danwt marked this pull request as draft April 8, 2024 11:07
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label May 21, 2024
@danwt danwt added the security label May 21, 2024
@omritoptix omritoptix removed the Stale label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin Awaiting requested review from mtsitrin

Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artemijspavlovs @danwt @omritoptix