Fix "Index consistency check failed" when running repair #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes duplicati#3202 Also add test to ensure that repair works as intended.
Compact used broken LocalDatabase.GetBlocklists without a hash check, so some backups may contain invalid index files.
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/backup-valid-but-still-unrestorable/6441/54 |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/250gb-downloaded-to-restore-a-2gb-backup/17827/9 |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/2-0-8-1-update-issue-broken-file-and-no-more-backup/17920/14 |
|
This pull request has been mentioned on Duplicati. There might be relevant details there: https://forum.duplicati.com/t/2-0-8-1-update-issue-broken-file-and-no-more-backup/17920/24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3202
Forum discussion
GROUP BY Hashto select any one of the possible blocklists in the database for each blocklist hash, so that re-use of blocks is ignoredSteps to test recreate hash check
list/[hash]and duplicate the contents of the file (append to the back)Old behavior
Recreated database has missing blocks and 2 broken filelists. Consider using "list-broken-files" and "purge-broken-files" to purge broken data from the remote store and the database.New behavior
[file] had invalid blocklists which could not be used. Consider deleting this index file and run repair to recreate it.Impact
This modifies a core SQL statement that will be used in repair, compact and to recreate missing index files. It should be tested that these work correctly for a backup with some data and a compact history.