Fix recovery tool empty file restore and other bugs #4991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4884
Steps to reproduce (single file error)
index .
in destination folderrestore . --targetfolder=restore
Current behavior
Removing common prefix ...\source\test.txt\
System.ArgumentOutOfRangeException
New behavior
Removing common prefix ...\source\
Steps to reproduce (empty file error)
index .
in destination folderrestore . --targetfolder=restore
Current behavior
System.Exception: Unable to locate block with hash: 47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=
New behavior
Steps to reproduce (unnecessary directory level)
source
index .
in destination folderrestore . --targetfolder=restore
Current behavior
restore\source
restore
contains only the single foldersource
that could be removed from the prefixNew behavior
restore
directlySteps to reproduce (directory separators)
index .
in destination folderrestore . --targetfolder=restore
Current behavior
New behavior