Fix force-locale option for CLI and GUI #4975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make the force-locale option work correctly:
There might be some issues with multiple threads which I have not tested (other threads within a backup operation might have the default locale for log messages again). For that we would need to find different translated log messages in the parallel runners (
DataBlockProcessor
,FileBlockProcessor
, ...). It might or might not be that the context is inherited when creating new threads.Closes #4176
Steps to reproduce (Backup job)
--force-locale
with a non-default languageCurrent behavior:
StartingOperation
)New behavior:
StartingOperation
)Steps to reproduce (help)
help advanced
command with--force-locale
set to a non-default languageCurrent behavior:
New behavior: