Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅(worker) Confirm we intercept synchronous throws #4987

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 15, 2024

Description

Just making sure that our package @fast-check/worker is able to intercept synchronously thrown errors and to report them as failures.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✅ Add or update tests
  • Impacts: None

Copy link

codesandbox-ci bot commented May 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2dae31d:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://664460039f7a1e65119b27e9--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (e70aea4) to head (2dae31d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4987   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files         213      213           
  Lines       16296    16296           
  Branches     2667     2658    -9     
=======================================
  Hits        15787    15787           
  Misses        509      509           
Flag Coverage Δ
unit-tests 96.87% <ø> (ø)
unit-tests-18.x-Linux 96.87% <ø> (ø)
unit-tests-20.x-Linux 96.87% <ø> (ø)
unit-tests-22.x-Linux ?
unit-tests-latest-Linux ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz enabled auto-merge (squash) May 15, 2024 07:22
Copy link
Contributor

👋 A preview of the new documentation is available at: http://66446415511c5f6480649ac1--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit b4242e6 into main May 15, 2024
60 checks passed
@dubzzz dubzzz deleted the sync-throw-worker branch May 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant