Fix json-schema type of objects nested under arrays. Fixes #400

[tomgi]

Fix for #400

Objects nested under arrays are not neccesailry arrays themselves - the :member option shouldn't be passed down the AST when generating json-schema.

For example for the test schema

dry-schema/spec/extensions/json_schema/schema_spec.rb

Lines 28 to 34 in 5853103

	required(:roles).array(:hash) do
	required(:name).value(:string, min_size?: 12, max_size?: 36)
	required(:metadata).hash do
	required(:assigned_at).value(:time)
	end
	end

the result of the fix is:

 {
   "$schema": "http://json-schema.org/draft-06/schema#",
   "type": "object",
   "properties": {
     "email": {
       "type": "string"
     },
     "age": {
       "type": "integer"
     },
     "roles": {
       "type": "array",
       "items": {
         "type": "object",
         "properties": {
           "name": {
             "type": "string",
             "minLength": 12,
             "maxLength": 36
           },
           "metadata": {
-            "type": "array",
-            "items": {
-              "type": "object",
-              "properties": {
-                "assigned_at": {
-                  "type": "string",
-                  "format": "time"
-                }
-              },
-              "required": [
-                "assigned_at"
-              ]
-            }
+            "type": "object",
+            "properties": {
+              "assigned_at": {
+                "format": "time",
+                "type": "string"
+              }
+            },
+            "required": [
+              "assigned_at"
+            ]
           }
         },
         "required": [
           "name",
           "metadata"
         ]
       }
     },
     "address": {
       "type": "object",
       "properties": {
         "street": {
           "type": "string"
         }
       },
       "required": [
 
       ]
     },
     "id": {
       "anyOf": [
         {
           "type": "string"
         },
         {
           "type": "integer"
         }
       ]
     }
   },
   "required": [
     "email",
     "roles",
     "id"
   ]
 }

[cpgo]

Hey @tomgi just asked about this issue on the zulip chat.
Tried monkey patching your solution on my project and it seems to be working perfectly.

@solnic is there any plans to merge this PR?

[shauns]

Following up on this -- @solnic would merging it be possible? The bug is still in place and this fix is a good one.

[solnic]

I'm sorry it took so long, I'll push a release, thanks for addressing it

[lukelex]

Awesome work. Thanks for dedicating your time to fix this ❤️