Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5655: Ensure that Drush 11 is tested on PHP 7.4 #5657

Open
wants to merge 2 commits into
base: 11.x
Choose a base branch
from
Open

Fixes #5655: Ensure that Drush 11 is tested on PHP 7.4 #5657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adc5c84
Fixes #5655: Ensure that Drush 11 is tested on PHP 7.4
greg-1-anderson Jun 14, 2023
616e83b
We should actually turn on the PHP 7.4 tests in Circle
greg-1-anderson Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,18 @@ jobs:
- image: cimg/mysql:5.7.38
<<: *test80steps

# PHP 7.4 test:
# Checks the most common configuration.
test_74_drupal9_mysql:
<<: *defaults
docker:
- image: wodby/php:7.4
environment:
- MYSQL_HOST=127.0.0.1
- UNISH_DB_URL=mysql://root:@127.0.0.1
- image: cimg/mysql:5.7.38
<<: *test80steps

test_80_drupal9_sqlite:
<<: *defaults
docker:
Expand Down Expand Up @@ -141,6 +153,8 @@ workflows:
jobs:
- code_style
- check_mergable
- test_74_drupal9_mysql:
<<: *requires
- test_80_drupal92_security:
<<: *requires
- test_80_drupal9_mysql:
Expand Down
2 changes: 1 addition & 1 deletion src/Drupal/Commands/config/ConfigCommands.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ public function status($options = ['state' => 'Only in DB,Only in sync dir,Diffe
* @param mixed $directory
* A configuration directory. Note; can be boolean.
*/
public static function getDirectory(mixed $directory = null): string
public static function getDirectory($directory = null): string
{
$return = null;
// If the user provided a directory, use it.
Expand Down