Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow migrate:import's --delete option to function #5063

Open
wants to merge 1 commit into
base: 11.x
Choose a base branch
from
Open

Allow migrate:import's --delete option to function #5063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Drupal/Migrate/MigrateExecutable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ protected function handleMissingSourceRows(MigrationInterface $migration): void

if ($destinationIds) {
$missingSourceEvent = new MigrateMissingSourceRowsEvent($migration, $destinationIds);
$this->getEventDispatcher()->dispatch($missingSourceEvent);
$this->getEventDispatcher()->dispatch($missingSourceEvent, MigrateMissingSourceRowsEvent::class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisolof, thank you for this catch. I think it should work also without the 2nd parameter. Could you try?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think I’m wrong. Will look during the weekend

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @chrisolof and @claudiu-cristea, it seems like this feature should ideally work.

}
}

Expand Down