[#266] Set minimum-stability to stable and added docs.
#667
Conversation
AlexSkrypnyk
force-pushed
the
feature/266-11x-min-stability
branch
from
d416363
to
425a118
Compare
composer.json
Outdated
| @@ -15,6 +15,7 @@ | |||
| "drupal/core-composer-scaffold": "^11@alpha", | |||
| "drupal/core-recommended": "^11@alpha", | |||
| "drush/drush": "^13@beta", | |||
| "chi-teck/drupal-code-generator": "4.x-dev#e61b917 as 3.5.0", | |||
There was a problem hiding this comment.
This package was updated to Symfony 7, but there is no release.
Considering that the whole 11.x branch is "early preview", I think this should be okay to have like this.
Once Drupal 11 is in beta and all these packages have their releases, we can clean it up.
AlexSkrypnyk
force-pushed
the
feature/266-11x-min-stability
branch
from
425a118
to
c0ac5e8
Compare
composer.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "chi-teck/drupal-code-generator": "4.x-dev#e61b917 as 3.5.0", | |||
There was a problem hiding this comment.
This package was updated to Symfony 7, but there is no release.
Considering that the whole 11.x branch is "early preview", I think this should be okay to have like this.
Once Drupal 11 is in beta and all these packages have their releases, we can clean it up.
I've created an issue - maybe we can wait for a couple of days before merging this one.
There was a problem hiding this comment.
I don't think you need to add as 3.5.0 unless another package explicitly needs that version. If you are using composer require ... it won't work because it checks stability. But if you just add it manually to the composer.json it works fine. This is a feature afaik.
To test, I updated it locally to be this and ran composer update.
"chi-teck/drupal-code-generator": "4.x-dev",
I don't know if pinning it to a commit hash is good... if the package maintainers happen to rewrite history on the dev branch then composer will stop building?
There was a problem hiding this comment.
it worked for you because you probably did not use the dev version of core.
Drush 13.x requires 4.x-dev for Symfony 7 compatibility https://github.com/drush-ops/drush/blob/13.x/composer.json#L36C3-L36C57
There was a problem hiding this comment.
chi-teck/drupal-code-generator is now released. waiting for Drush to start using it at alpha+ version level.
There was a problem hiding this comment.
There was a problem hiding this comment.
it worked for you because you probably did not use the dev version of core.
Sorry I isn't sinking in why this project needs to use the dev version of core.
AlexSkrypnyk
added
D11
PR: Needs review
| @@ -36,7 +37,7 @@ | |||
| "url": "https://asset-packagist.org" | |||
| } | |||
| ], | |||
| "minimum-stability": "dev", | |||
| "minimum-stability": "alpha", | |||
AlexSkrypnyk
force-pushed
the
feature/266-11x-min-stability
branch
4 times, most recently
from
cc60531
to
f5a4641
Compare
leymannx
changed the title
minimum-stability to true and added docs.minimum-stability to stable and added docs.
AlexSkrypnyk
force-pushed
the
feature/266-11x-min-stability
branch
from
f5a4641
to
fca7327
Compare
|
@leymannx |
AlexSkrypnyk
added
BLOCKED
AlexSkrypnyk
force-pushed
the
feature/266-11x-min-stability
branch
from
fca7327
to
2b64fbc
Compare
AlexSkrypnyk
removed
BLOCKED
Closes #266