Update README.md to provide installation guide for mac / linux users #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide installation guide when installing in Mac / Linux
Owen-CH-Leung
changed the title
|
@drahnr Just fixed the failing CI test. Can I seek your review ? Many thanks |
drahnr
force-pushed
the
update_readme_for_installation_guide
branch
from
398570f
to
2616957
Compare
drahnr
reviewed
May 27, 2024
README.md
Outdated
| @@ -61,6 +61,33 @@ cargo spellcheck fix | |||
| The `--locked` flag is the preferred way of installing to get the tested set of | |||
| dependencies. | |||
|
|
|||
| in Mac, you'd need to ensure that `libclang.dylib` can be found by the linker | |||
There was a problem hiding this comment.
Suggested change
| in Mac, you'd need to ensure that `libclang.dylib` can be found by the linker | |
| on OS X, you need to ensure that `libclang.dylib` can be found by the linker |
drahnr
reviewed
May 27, 2024
drahnr
reviewed
May 27, 2024
drahnr
approved these changes
May 27, 2024
|
Could you squash it into one commit, then we can merge it :) Thank you! |
Thanks. Updated |
Bumps [h2](https://github.com/hyperium/h2) from 0.3.21 to 0.3.26. - [Release notes](https://github.com/hyperium/h2/releases) - [Changelog](https://github.com/hyperium/h2/blob/v0.3.26/CHANGELOG.md) - [Commits](hyperium/h2@v0.3.21...v0.3.26) --- updated-dependencies: - dependency-name: h2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> chore(deps): bump rustls from 0.21.7 to 0.21.11 Bumps [rustls](https://github.com/rustls/rustls) from 0.21.7 to 0.21.11. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.21.7...v/0.21.11) --- updated-dependencies: - dependency-name: rustls dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> fix dead_code compile error Removes the unused CommonLang type. chore/deps: bump pulldown-cmark to 0.10.0 chore: fmt chore/deps: cargo_toml, itertools, fancy-regex, env_logger chore/deps: bump ra_ap_syntax chore: clippy, disable pedantic, explicitly allow a few pedantic chore: bail if neither feature of `nlprules` or `hunspell` were set. release: v0.14.0 feat: ignore math content enclodes by `$` build: run cargo update to make it compile for riscv64 Update README.md Provide installation guide when installing in Mac / Linux Fix failing CI Revise ReadME
Owen-CH-Leung
force-pushed
the
update_readme_for_installation_guide
branch
from
34713c2
to
38bb7a6
Compare
|
bad rebase =( Let me create another branch instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdto provide a detailed installation guide for mac & linux users.Closes #320 .
馃摐 Checklist
./demosub directory