Add missing degree to radian conversion #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the code I saw the moon-earth-sun positions where not on a single line as expected for a full moon day (2022-08-12). After checking the calculations with the example in https://www.stjarnhimlen.se/comp/tutorial.html#5 I found the missing conversion from degrees to radians in celestial_bodies() in solar.cpp. With thr converion added I get the correct positions for a full moon and the equinoxes. The sister project for the pico has the conversion included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the code I saw the moon-earth-sun positions where not on a single line as expected for a full moon day (2022-08-12). After checking the calculations with the example in https://www.stjarnhimlen.se/comp/tutorial.html#5 I found the missing conversion from degrees to radians in celestial_bodies() in solar.cpp.
With the conversion added I get the correct positions for a full moon and the equinoxes.
The sister project for the pico has the conversion included.