Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refactoring in tooltips #11388

Merged
merged 1 commit into from
May 22, 2024

Conversation

Tanya-Solyanik
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik commented May 16, 2024

Introduced in ca1199e -

Tooltip owner window is used for tooltip placement when tool is not a control, this is the case of ToolStripItems.

Microsoft Reviewers: Open in CodeFlow

tooltip owner window is used for tooltip placement when tool is not a control, thisis the case of ToolStripItems.
@elachlan
Copy link
Contributor

elachlan commented May 16, 2024

Test failure unrelated.

System.Windows.Forms.Tests.ClipboardTests.Clipboard_SetText_InvokeStringTextDataFormat_GetReturnsExpected(format: Text)

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.26649%. Comparing base (31176a4) to head (0433fde).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11388         +/-   ##
===================================================
- Coverage   74.27181%   74.26649%   -0.00532%     
===================================================
  Files           3025        3025                 
  Lines         626861      626852          -9     
  Branches       46742       46740          -2     
===================================================
- Hits          465581      465541         -40     
- Misses        157935      157958         +23     
- Partials        3345        3353          +8     
Flag Coverage Δ
Debug 74.26649% <0.00000%> (-0.00532%) ⬇️
integration 17.98313% <0.00000%> (-0.01878%) ⬇️
production 46.98492% <0.00000%> (-0.01257%) ⬇️
test 96.99415% <ø> (ø)
unit 43.97002% <0.00000%> (+0.00208%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 17, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit 28b156a into dotnet:main May 22, 2024
8 checks passed
@Tanya-Solyanik Tanya-Solyanik deleted the keyboard-tooltip branch May 22, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants