This repository has been archived by the owner on May 17, 2024. It is now read-only.
.NET 6 #437
Open
.NET 6 #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
approved these changes
May 17, 2022
dil-mocsy
reviewed
Sep 6, 2022
| @@ -296,8 +296,8 @@ public static class MSBuildFacts | |||
| public const string PackagesSubstring = @"\packages"; | |||
| public const string NetStandard20 = "netstandard2.0"; | |||
| public const string NetCoreApp31 = "netcoreapp3.1"; | |||
| public const string Net5 = "net5.0"; | |||
| public const string Net5Windows = "net5.0-windows"; | |||
| public const string Net5 = "net6.0"; | |||
There was a problem hiding this comment.
I don't know this code, but having a const named Net5 with value net6.0 looks misleading.
There was a problem hiding this comment.
I guess time to update to .NET 8.0 now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.