Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.4xx] Update dependencies from dotnet/linker #40980

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 17, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: f9820654-7ba0-45dd-803d-08dc74de8f36
  • Build: 20240520.5
  • Date Produced: May 20, 2024 11:05:27 PM UTC
  • Commit: e66cbcaa36aa719936a46160198c9012c6e174e4
  • Branch: refs/heads/release/6.0.x

…419.1

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.200-1.22553.1 -> To Version 6.0.200-1.24219.1
@baronfel
Copy link
Member

This fixes #29927

@marcpopMSFT
Copy link
Member

@dotnet/source-build-internal It's looking for a linker SB package and can't find it. I couldn't find it either when searching through darc:
Unable to find package Microsoft.SourceBuild.Intermediate.linker with version (= 6.0.200-1.24219.1)

…517.3

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.200-1.22553.1 -> To Version 6.0.200-1.24267.3
@ellahathaway
Copy link
Member

ellahathaway commented May 20, 2024

@dotnet/source-build-internal It's looking for a linker SB package and can't find it. I couldn't find it either when searching through darc: Unable to find package Microsoft.SourceBuild.Intermediate.linker with version (= 6.0.200-1.24219.1)

Hm I also can't find it in any of the feeds. I went through the internal linker pipeline, and the 6.0 runs don't have a source-build leg... not sure why that is, but it would explain why the package doesn't exist. The public runs do source-build, however.

@dotnet/source-build-internal - Do we know why linker's 6.0 runs don't include a source-build leg? Link to pipeline run (internal Microsoft link). I'm wondering if the lack of the build leg is intentional or not.

@MichaelSimons
Copy link
Member

@dotnet/source-build-internal - Do we know why linker's 6.0 runs don't include a source-build leg? Link to pipeline run (internal Microsoft link). I'm wondering if the lack of the build leg is intentional or not.

This looks to be the result of dotnet/linker#3245 which introduced a new official build pipeline without a source-build leg. cc @agocke.

@MichaelSimons
Copy link
Member

Given we don't support source-build in 6.0.4xx we could switch the version.details.xml dependency to use the SourceBuildTarball attribute instead of SourceBuild. This will avoid trying to load the intermediate for the dependency but still include the dependency in the source tarball.

@agocke
Copy link
Member

agocke commented May 20, 2024

@dotnet/source-build-internal - Do we know why linker's 6.0 runs don't include a source-build leg? Link to pipeline run (internal Microsoft link). I'm wondering if the lack of the build leg is intentional or not.

This looks to be the result of dotnet/linker#3245 which introduced a new official build pipeline without a source-build leg. cc @agocke.

Looks like I dropped it during 1ES conversion. I can just copy over the previous definition, if that's sufficient.

…520.5

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.200-1.22553.1 -> To Version 6.0.200-1.24270.5
@v-wuzhai v-wuzhai merged commit 037df91 into release/6.0.4xx May 21, 2024
15 of 16 checks passed
@v-wuzhai v-wuzhai deleted the darc-release/6.0.4xx-3f7a7b87-6230-4867-9bb7-223009cb2d2e branch May 21, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ILLink Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants