Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] Backport "Merge CoreCLR-based official builds legs into one leg per platform" #102097

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented May 10, 2024

This is part of the work to transition to the 1ES templates in servicing branches.

Backporting #92901 and #93078.

Official build (96b1946): https://dev.azure.com/dnceng/internal/_build/results?buildId=2449124&view=results

cc @jkoritzinsky @agocke @amanasifkhalid

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 10, 2024
@eduardo-vp eduardo-vp added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 10, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@eduardo-vp
Copy link
Member Author

The failed check is a known error

@eduardo-vp eduardo-vp marked this pull request as ready for review May 10, 2024 22:27
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't knnow much about the crossdac, but this LGTM

@eduardo-vp eduardo-vp requested a review from hoyosjs May 14, 2024 19:16
@eduardo-vp eduardo-vp added the Servicing-consider Issue for next servicing release review label May 14, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we can treat this as tell mode and merge when ready.

cc @carlossanlop

@eduardo-vp eduardo-vp added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 14, 2024
@eduardo-vp eduardo-vp merged commit bb432d7 into dotnet:release/8.0-staging May 14, 2024
175 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants