Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeSpanConverter: Less restrict in-range check to allow more timespan formats that would be accepted by Utf8Parser.TryParse #102091

Merged
merged 1 commit into from May 13, 2024
Merged

TimeSpanConverter: Less restrict in-range check to allow more timespan formats that would be accepted by Utf8Parser.TryParse #102091

merged 1 commit into from May 13, 2024

Conversation

danielmarbach
Copy link
Contributor

Fix #100538

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 10, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@danielmarbach danielmarbach mentioned this pull request May 10, 2024
Closed
eerhardt
eerhardt approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Thank you for the fix!

@danielmarbach danielmarbach force-pushed the issue-100538 branch 3 times, most recently from eb2696c to b5f4d3f Compare May 11, 2024 22:14
This was referenced May 12, 2024
Open
Open
Open
Open
@danielmarbach

This comment was marked as resolved.

Sign in to view
@danielmarbach

This comment was marked as resolved.

Sign in to view
@danielmarbach
Copy link
Contributor Author

Rebased

@eiriktsarpalis
Copy link
Member

Thanks @danielmarbach!

@eiriktsarpalis eiriktsarpalis merged commit 78c8cb9 into dotnet:main May 13, 2024
83 checks passed
@danielmarbach danielmarbach deleted the issue-100538 branch May 13, 2024 16:34
@danielmarbach
Copy link
Contributor Author

Thank you too @eiriktsarpalis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-System.Text.Json community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonSerializer doesn't support valid TimeSpan formats
3 participants
@danielmarbach @eiriktsarpalis @eerhardt