Enable repackaging of NETStandard 2.1 Targeting Pack #102081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #99610
This PR has the same changes as #101518, with the additional small change, to fix the issue with official CI. Original PR was reverted. This is now targeting 8.0.7 release. Validation build was successful: https://dev.azure.com/dnceng/internal/_build/results?buildId=2447965&view=results
Current NETStandard 2.1 targeting pack package does not support installation on FIPS-enabled systems. Original repo and branch (core-setup, release/3.1) have been deprecated and cannot be used for building this package anymore.
The solution is to repackage it. Extraction is done using
rpm2cpio <original-package> | cpio -idmv
which preserves original content and file modification time. Packaging is done with FPM, using regular tooling for RPM package creation. This tooling supports FIPS, by enabling sha256 package digest.There are some small differences in metadata - description and packager fields, as well as copyright. Details are available in the appropriate sections.
Naming and versioning
Old package name was
netstandard-targeting-pack-2.1.0-x64.rpm
as it did not get renamed during publishing to PMC. New packages will get renamed to follow common naming schema. New package name will be:netstandard-targeting-pack-2.1-8.0.6-1.x86_64.rpm
Copyright differences
There is a minor difference in the comment section of the copyright file that ships with this package. It is picked up from new packaging infra. I've attached old and new copyright files, for review. I've outlined the differences.
Package metadata differences
Version
difference is intentional as a result of building in 8.0 servicing branch. This can likely be tweaked if needed, but it is a correct model as this is how distros version the same package, in their servicing releases.Packager
andDescription
values are coming from new package infra - shared with all packages produced in 8.0 release. This can likely be tweaked if needed. I've outlined the differences.I've attached the full metadata content as files, for review.
Testing
metadata.new.txt
metadata.original.txt
copyright.new.txt
copyright.original.txt