Don't propagate VE.Frame changes back down to the Handler #22347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
PureWeen
added
area-controls-general
PureWeen
changed the title
mattleibow
reviewed
May 15, 2024
mattleibow
approved these changes
May 15, 2024
This was referenced May 15, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The Height and Width Property aren't really meant to propagate back down to the handler. These properties are only set when the platform code updates the VisualElement.Frame property, indicating what the actual width and height of the platform element are. WidthRequest and HeightRequest are the properties that we use to propagate changes down to the Handler and those will still propagate down via the
OnRequestChangecallsIssues Fixed
Fixes #22271