[Trimming] Add ILC compilation test of all assemblies #22328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbomer
reviewed
May 10, 2024
| { | ||
| result = (Effect)DependencyResolver.ResolveOrCreate(effectType); | ||
| result = (Effect)DependencyResolver.ResolveOrCreate(effectType.Type); |
There was a problem hiding this comment.
This missing analyzer warning is tracked by dotnet/runtime#101734.
Eilon
added
the
area-publishing
jonathanpeppers
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds a test following this guide: https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#publishing-a-test-application-for-aot
The rest of the changes are warnings that were discovered via ILC but were not reported by the trimming and AOT analyzers.
/cc @sbomer
Issues Fixed
Fixes #22310