[iOS] Fix CarouselView loading previous item #22280
Conversation
rmarinho
added
platform/iOS 🍎
area-controls-collectionview
|
cc @filipnavara if we have ideas to fix this one better. |
| @@ -44,5 +44,10 @@ protected override bool AttributesConsistentWithConstrainedDimension(UICollectio | |||
| { | |||
| return false; | |||
| } | |||
|
|
|||
| public override void PrepareForReuse() | |||
There was a problem hiding this comment.
This is reverting changes and fixing the issue or just include the reverts?. Could we include a comment here to avoid remove it by mistake?
There was a problem hiding this comment.
this fixes the issue, but I still investigating a better way.
| @@ -82,9 +82,8 @@ | |||
| CurrentItem="{Binding Selected}"> | |||
| <CarouselView.ItemTemplate> | |||
| <DataTemplate> | |||
| <Frame | |||
| <Border | |||
There was a problem hiding this comment.
Could we create also an UITest?
There was a problem hiding this comment.
Unfortunately I don't. I think we only used carousels in our app for full-page transitions and we ended up running into so many issues that we wrote a handler using |
|
This one is a bit scary and weird. The item vanishes when scrolling, so this PR is going to prevent any release of things. But, why does it not come back? This is normal CV functionality. If I go from page 1 to page 2, when I go back to page 1 - the normal things should be working to reload the view A multiple loading may be a bit bad, but saying "just never undo/unsubscribe/release" is NOT the better option maybe? |
Description of Change
Some performance enhancements that were done with Unbind, seem to have broken the previous cell on CarouselView.
This does't seem the correct fix yet , but is a start in reverting the regression.
Issues Fixed
Fixes #22015