Fix shadow copy up to date check on startup (#52831)

[BrennanConroy]

Backport of #52831

Fix shadow copy up to date check on startup

Description

If using shadow copy in ANCM and you shutdown the app (e.g. app_offline.htm) then delete a subfolder (with a dll), starting up the app can cause a crash that can only be resolved by adding back the deleted folder. Or resolved by deleting the shadow copy folder (either manually or with cleanShadowCopyDirectory setting turned on).

Customer Impact

App permanently crashes on startup until moving app to a new directory, cleaning shadow copy folders, or readding removed file. This is a hard to diagnose issue as it's just a random crash with little info about what happened.

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Code was obviously wrong once the issue was looked into, very simple fix. Added a test to verify.

Verification

• Automatic

Packaging changes reviewed?

• Yes
• No
• N/A

[halter73]

I know this is unchanged, but why is this logic different than CopyToDirectoryInner? It feels like we should use the same logic in both places if possible. We could do that in main though.

            auto sourceInnerDirectory = path.path();

            if (sourceInnerDirectory.wstring().rfind(directoryToIgnore, 0) != 0)

And what is auto sourceInnerDirectory = std::filesystem::directory_entry(path); doing? Isn't path already a directory_entry?

[BrennanConroy]

Backport to 8.0 rejected. Signal is low for this and there is a workaround listed in the issue and below. If someone hits the issue they can find the stack trace from event viewer in the original github issues.

Can resolve the issue by deleting the shadow copy folder (either manually or with cleanShadowCopyDirectory setting turned on). Can avoid the issue by setting cleanShadowCopyDirectory or by not changing folders/files of published app unless shadow copy directories are removed.