New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JSON source generator in WebApplicationFactory #55595
base: main
Are you sure you want to change the base?
Use JSON source generator in WebApplicationFactory #55595
Conversation
Just noticed that the old labels were set manually. Why networking, @mkArtakMSFT? |
FYI @captainsafia |
Use JSON source generator to deserialize dictionary. Resolves dotnet#55586.
a477d21
to
0efaa78
Compare
@martincostello TY for the PR. We reference the Mvc.Testing package in other tests in the repo (Identity.FunctionalTests, MvcFunctionalTest, for example). We can probably verify whether or not this fix applies by setting the |
Playing around with Microsoft.AspNetCore.Mvc.FunctionalTests locally I get the following results:
The tests that fail for me regardless of the settings are from |
|
Use JSON source generator in WebApplicationFactory
Use JSON source generator to deserialize dictionary.
Description
Use JSON source generator to deserialize JSON to prevent
InvalidOperationException
in a test project withJsonSerializerIsReflectionEnabledByDefault=false
.I wasn't sure how to test this without having to add an entirely new test project - happy to add something if someone can give a suggestion on how to go about that in a way that would be acceptable to the team.
Fixes #55586