Experimental revert of P/Invoke layer #55519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f18f8f. # Conflicts: # eng/Versions.props # src/Servers/HttpSys/src/AsyncAcceptContext.cs # src/Servers/HttpSys/src/AuthenticationManager.cs # src/Servers/HttpSys/src/Microsoft.AspNetCore.Server.HttpSys.csproj # src/Servers/HttpSys/src/NativeMethods.txt # src/Servers/IIS/IIS/src/Microsoft.AspNetCore.Server.IIS.csproj
…kerberos caching etc)
dotnet-issue-labeler
bot
added
the
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft while planning.
Reason: reports of unusual http.sys failures since .NET 8 migration; only relevant PR is this one; we have been unable to isolate whether this is the cause, so we're discussing whether to issue a private build to the affected party, to see whether this resolves it.
This PR is a revert of #50685, taking into account #54368 (which was investigatory for the same problem) and #51833 (ex-flags; note the second PR in this branch is fallout from the last - our
ExFlagshad never been used and was mis-declared; it isbytein the main generated code, and making that change fixes relevant failing tests)/cc @Tratcher for input on whether this is a bad direction (ideally with alternative suggestions)