Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather assembly references #2508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Gather assembly references #2508

wants to merge 1 commit into from

Conversation

timcassell
Copy link
Collaborator

@timcassell timcassell commented Jan 23, 2024

Fixes #1197
Fixes #2344
Also fixes legacy packages.config issues with CsProjClassicNetToolchain (no open issue, but was mentioned in #2405 (comment)).
And this is a pre-requisite to adding support for extern alias (#2289).

@timcassell

This comment was marked as off-topic.

@timcassell timcassell marked this pull request as ready for review January 23, 2024 13:16
@timcassell
Copy link
Collaborator Author

@AndreyAkinshin Can we get this in v0.14.0 also? Then I can make a follow-up PR changing the default .Net Framework toolchain to CsProjClassicNetToolchain instead of RoslynToolchain (this fixes the issue we ran into when we tried to do that in v.0.13.7).

@AndreyAkinshin
Copy link
Member

@timcassell yes, we can, sorry for such a delay. I will check it out as soon as I have some time for that (I want to carefully review the changes, not just blindly merge it).

@Tampa
Copy link

Tampa commented Apr 11, 2024

@AndreyAkinshin It's been two months since. What's the status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when returning type from PackageReference Enable including references in autogenerated csproject
3 participants