Create empty Directory.Build.props to ignore other prop files #2467
+16
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2371 (comment)
It should not affect the WASM benchmarks (cc @radical), as they have their own generator:
BenchmarkDotNet/src/BenchmarkDotNet/Toolchains/MonoWasm/WasmGenerator.cs
Line 52 in 630622b
BenchmarkDotNet/src/BenchmarkDotNet/Templates/WasmCsProj.txt
Lines 3 to 5 in 630622b
which links a dedicated props file: https://github.com/dotnet/performance/blob/main/src/benchmarks/micro/MicroBenchmarks.Wasm.props
But I am not sure about dotnet/performance in general, as IIRC the props file there alters some settings like build output path. This is going to require a detailed testing (@cincuranet @LoopedBard3 @DrewScoggins @caaavik-msft @sblom)
fixes #2371