New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-PR review. #32562
Post-PR review. #32562
Conversation
Search and replace here -- too verbose
|
remove all FT. |
Split up
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrite
Operation transformers apply to each individual operation (combination of path + HTTP method) and can be used to modify parameters or responses on endpoints.
Operation transformers apply to each individual operation, modifying parameters or responses on endpoints. These operations are a combination of the path and the HTTP method.
LInk to source on new APIs, ie
https://github.com/dotnet/aspnetcore/blob/main/src/OpenApi/src/Transformers/IOpenApiDocumentTransformer.cs#L9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aspnetcore\src\Mvc\Mvc.ApiExplorer\src\ApiDescriptionGroupCollectionProvider.cs
contains ApiDescriptionGroups
Probably create another PR to update these ref when the API is built. It's nice to have a link to the source and the API ref.
he sample below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on the style guide but the content looks fine.
I've added a suggestion for the missing code snippet for multi-doc transformers.
Co-authored-by: Safia Abdalla <safia@safia.rocks>
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
Review of the article created by #32529
Mostly changes to conform to the style guide.
On periods in bulleted lists, see https://styleguides.azurewebsites.net/Styleguide/Read?id=2700&topicid=56575
Internal previews