Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: install doctest_with_main as a target if built #837

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

tchernobog
Copy link

Description

This change allows installing and exporting the static library target doctest::doctest_with_main if the project is configured with DOCTEST_WITH_MAIN_IN_STATIC_LIB.

This is required for usage in third-party projects that install doctest at the package-manager level.

GitHub Issues

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a01ec3) 92.11% compared to head (d8bd40e) 92.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #837   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files           2        2           
  Lines        2168     2168           
=======================================
  Hits         1997     1997           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchernobog
Copy link
Author

@onqtam I am not sure about the CI failures I am seeing, they mostly seem independent from my change... ?

@onqtam
Copy link
Member

onqtam commented Jan 8, 2024

Hey, I'm simply unable to review the PR appropriately at this time. Also, it's directed towards the master branch instead of dev...

@tchernobog tchernobog changed the base branch from master to dev January 9, 2024 10:40
This change allows installing and exporting the static library
target doctest::doctest_with_main if the project is configured
with DOCTEST_WITH_MAIN_IN_STATIC_LIB.

This is required for usage in third-party projects that install
doctest at the package-manager level.
@tchernobog
Copy link
Author

Hey, I'm simply unable to review the PR appropriately at this time. Also, it's directed towards the master branch instead of dev...

@onqtam I rebased on top of dev. I think my change is correct, and the CI failures are unrelated.

Who would be able to review this small change?

@onqtam
Copy link
Member

onqtam commented Jan 9, 2024

Hey, I'm simply unable to review the PR appropriately at this time. Also, it's directed towards the master branch instead of dev...

@onqtam I rebased on top of dev. I think my change is correct, and the CI failures are unrelated.

Who would be able to review this small change?

Not sure... see this for context: #554 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants