Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Clang 16 warnings. Closes #766 #768

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

HolyBlackCat
Copy link

Description

What: Silence Clang 16's -Wunsafe-buffer-usage.
Why: That + -Werror causes build errors in the examples.

GitHub Issues

#766

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #768 (9336c9b) into dev (ae7a135) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #768   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files           2        2           
  Lines        2169     2169           
=======================================
  Hits         1998     1998           
  Misses        171      171           
Impacted Files Coverage Δ
doctest/parts/doctest_fwd.h 96.55% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@onqtam
Copy link
Member

onqtam commented Apr 12, 2023

if the warning suppression is not recognized by most clang versions it can be made conditional with ifdefs only for clang 16 and if it happens only in 1-2 places it can also be made locally there. Also seems that clang 16 is harder to add to the build matrix

@HolyBlackCat
Copy link
Author

HolyBlackCat commented Apr 16, 2023

@onqtam I think I've fixed it.

But some unrelated CI jobs are stuck as 'queued' me. 🤔 (upd: the jobs ultimately failed, but the same thing happened in the other PR too, so I don't think I did that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants