Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean clang-tidy with DOCTEST_CONFIG_DISABLE #708

Open
wants to merge 35 commits into
base: dev
Choose a base branch
from
Open

Clean clang-tidy with DOCTEST_CONFIG_DISABLE #708

wants to merge 35 commits into from

Conversation

Saalvage
Copy link
Member

@Saalvage Saalvage commented Oct 4, 2022

Fixes #691

DanielKriz and others added 30 commits September 13, 2022 04:36
@DanielKriz
Fix CMake example in docs (#692)
0593a80 
Name of target is different from the name of executable. Therefore this
example would fail in the generation phase.
@tocic
Fix typos in docs (#694)
8e963e8
@Saalvage
Suppress new warning
e331f32
@falbrechtskirchinger
Restore WIN32_LEAN_AND_MEAN and NOMINMAX (#697)
ddd12fe
@KiruyaMomochi
Use variables instead of hard-coded mpirun -np (#689)
f5d122b 
CMake's `FindMPI` module sets `MPIEXEC_EXECUTABLE` and `MPIEXEC_NUMPROC_FLAG`. We use them so it works for different MPI implementations.
@SpriteOvO @Saalvage
Fix compile errors when comparing pointers. (#699)
0c04c96 
* Explicitly convert pointer in `filldata<T*>::fill`

* Add regression test

* Increase standard compliance

* Collect test output

* Collect test output

* Fix warnings

* Add GCC workaround

* Update doctest.h

* Move __extension__

* Use different workaround

* Add missing const qualifier

Co-authored-by: Salvage <29021710+Saalvage@users.noreply.github.com>
@bnason-nf @Saalvage
Suppress hash() clang integer sanitizer issues (#667)
4e38208 
* Add sanitizer CI

* Fix setup

* Separate sanatizers

* Add integer sanitizers

* Finalize sanitizer list

* Specify libc++

* Remove overly complicated sanitizers

* Readd removed CI

* Suppress hash() clang integer sanitizer issues

* Add changes to parts

* Add version limit

Co-authored-by: Stefan <29021710+Saalvage@users.noreply.github.com>
@Saalvage
Test flags CI
3ea68ec
@Saalvage
Fix unused template
124156f
@Saalvage
Add consumption
18d3931
@Saalvage
Reconsume
829e971
@Saalvage
Remove semicolon and return 0
95ef168
@Saalvage
Consume all
5be4cc6
@Saalvage
nolintbegin/end
8543586
@Saalvage
Clang warnings
aa91215
@Saalvage
More suppression
3e377a0
@Saalvage
Test manual consume
8344b14
@Saalvage
Final suppression
f175167
@Saalvage
Use NOLINT instead
bf84bb8
@Saalvage
begin/end
b3fa27d
@Saalvage
Move it into the macro
4b65af2
@Saalvage
Generic suppress
07318b2
@Saalvage
Suppress in workflow
add7f30
@Saalvage
Ok let's do it this way
808a0e0
@Saalvage
Upgrade clang tidy version?
e93c35c
@Saalvage
Maybe this way??
a18dfe8
@Saalvage
More suppressions yet again
d360d63
@Saalvage
Update doctest.h
43bdad2
@Saalvage
Yet more
3b85456
@Saalvage
Disable all warnings
425e5c0
@Saalvage Saalvage linked an issue Oct 4, 2022 that may be closed by this pull request
clang-tidy gives warnings of unused variables in test cases when compiled without doctest #691
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang-tidy gives warnings of unused variables in test cases when compiled without doctest
7 participants
@Saalvage @DanielKriz @tocic @falbrechtskirchinger @KiruyaMomochi @SpriteOvO @bnason-nf