fix deprecation warnings and other lints #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walles
added a commit
to walles/px
that referenced
this pull request
Feb 8, 2019
Fails in CI, not locally. The failure is a SyntaxError in Docopt 0.6.2: docopt/docopt#435 But no Docopt release has been made since 2014, so we need to replace it to fix this.
|
merged at jazzband/docopt-ng#3 - thanks! |
|
@itdaniher neat project, thanks for taking it on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I vendor
docopt.pyin some of my projects, and I seeDeprecationWarning: invalid escape sequencewhen I runpytestacross the whole project, because it's searchingdocopt.pyfor tests and hitting those warnings. As part of fixing that, I figured it would be nice to fix all theflake8lints, at least in that one file. There are a few:#.I also added
flake8totox.ini, which helped to catch that 2.7-only lint above.If this is all too aggressive, I could rip out all of these changes except the escape sequence fixes, which is the only thing I think we genuinely need.